chore(deps): bump npm minor/patch group, redis 6, tar, simple-import-sort - #474
Conversation
…imple-import-sort Consolidate Dependabot updates from #469–#472 and most of #471: - Root tooling: eslint 10.8, globals, knip, nuxt 4.5.1, prettier 3.9.6, typescript-eslint 8.65+, vue-language-core/vue-tsc 3.3.8+, simple-import-sort 14 - API/web: sentry 10.69, wrangler 4.115+, workers-types, @types/node 26.1.2 - Storage/api-node: aws-sdk 3.1098+, sentry - Web: stripe-js, tiptap 3.29.2 (incl. pm), nuxt 4.5.1 - media-pipeline: redis ^6.1.0 - Override tar >=7.5.22 (transitive via @mapbox/node-pre-gyp) Deferred: - typescript 7.0.2 — typescript-eslint peer still requires <6.1.0 (#468) - @moq/net/@moq/watch — MultiBackend removed in 0.4.x; needs a migration PR (#471) Co-authored-by: Jakub Doboš <[email protected]>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe pull request updates dependency versions and the root ChangesDependency refresh
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit dd404af
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
ReturnType<typeof createClient> is overloaded across RESP versions; pin a
concrete PackagingRedisClient from createClient({ url }) so tsc accepts the
redis@6 default RESP3 client.
Co-authored-by: Jakub Doboš <[email protected]>
There was a problem hiding this comment.
🧹 Nitpick comments (1)
package.json (1)
59-60: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winUnbounded lower-bound override on
tarallows unconstrained future major versions.The
taroverride uses">=7.5.22"with no upper bound, so any future major release oftar(v8, v9, etc.) will be installed transitively without any manual gate. This is riskier than the neighboringwsoverride on Line 59, which pins an exact version. Since this override was added specifically to remediate a known issue in the ^7.4.0 range used transitively (per thepackage-lock.jsoncontext), a caret range such as"^7.5.22"would satisfy the same remediation while still blocking unreviewed breaking changes from a future major bump.♻️ Proposed fix to bound the tar override
- "tar": ">=7.5.22" + "tar": "^7.5.22"🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@package.json` around lines 59 - 60, Update the tar override in package.json from the unbounded >=7.5.22 range to a caret-bounded ^7.5.22 range, preserving the remediation while preventing automatic adoption of future major versions.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@package.json`:
- Around line 59-60: Update the tar override in package.json from the unbounded
>=7.5.22 range to a caret-bounded ^7.5.22 range, preserving the remediation
while preventing automatic adoption of future major versions.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 1acb3cf1-3d70-4fee-b2b1-33219b4ce00e
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (9)
package.jsonpackages/api-node/package.jsonpackages/api/package.jsonpackages/media-pipeline/package.jsonpackages/media-pipeline/packagingQueue.tspackages/offloading/package.jsonpackages/payments/package.jsonpackages/storage/package.jsonpackages/web/package.json
Keep the security floor at 7.5.22 while preventing automatic adoption of a future major via the previous unbounded >= range. Co-authored-by: Jakub Doboš <[email protected]>
Consolidates Dependabot PRs #469, #470, #471 (partial), and #472 into one lockfile-consistent update on current
main.Included
^7.5.22(#472; transitive via@mapbox/node-pre-gyp)Code fix for redis 6
packages/media-pipeline/packagingQueue.ts— use a concrete client type fromcreateClient({ url })so TypeScript accepts redis@6’s default RESP3 typing (fixes media-pipeline Dockertscbuild).Deferred (with reasons)
typescript-eslintpeer still requirestypescript@>=4.8.4 <6.1.0(including latest 8.66.x).npm cifails without--legacy-peer-deps.@moq/net/@moq/watch(#471)MultiBackend; watch page + composable still use that API. Needs a dedicated MoQ player migration (prefer<moq-watch>element).Files changed
package.json/package-lock.json— root deps +taroverride (^7.5.22)packages/api/package.json— sentry, workers-types, @types/node, wranglerpackages/api-node/package.json— aws-sdk, sentry, workers-types, @types/nodepackages/storage/package.json— aws-sdk, workers-types, @types/nodepackages/web/package.json— sentry, stripe, tiptap, nuxt, vue-tsc, wrangler, @types/nodepackages/media-pipeline/package.json— redis, @types/nodepackages/media-pipeline/packagingQueue.ts— redis@6 typingpackages/payments/package.json,packages/offloading/package.json— @types/nodeVerification
npm run typecheck(shared, storage, api, api-node, web)npm run verify:api-nodenpm run build --workspace=@vmp/media-pipelineAfter merge, close Dependabot PRs #469–#472 (and #471 if MoQ remains deferred).
Summary by CodeRabbit